Skip to content

PR: Update minimal required version of pylint to >=2.5.0,<3.1#21470

Merged
ccordoba12 merged 4 commits intospyder-ide:5.xfrom
bnavigator:pylint3
Oct 31, 2023
Merged

PR: Update minimal required version of pylint to >=2.5.0,<3.1#21470
ccordoba12 merged 4 commits intospyder-ide:5.xfrom
bnavigator:pylint3

Conversation

@bnavigator
Copy link
Copy Markdown
Contributor

@bnavigator bnavigator commented Oct 29, 2023

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Pylint 3 removed long deprecated find_pylintrc() which was only a wrapper to find_default_config_files().
pylint-dev/pylint#9105

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
bnavigator

@bnavigator bnavigator changed the title Pylint3 Update to pylint 3 Oct 29, 2023
@dalthviz dalthviz changed the title Update to pylint 3 PR: Update to pylint 3 Oct 30, 2023
@dalthviz dalthviz changed the title PR: Update to pylint 3 PR: Update minimal required version of pylint to >=2.5.0,<3.1 Oct 30, 2023
@dalthviz
Copy link
Copy Markdown
Member

dalthviz commented Oct 30, 2023

Note: If we decide to include this on 5.5.0, this will need to be rebased into the 5.x branch

@ccordoba12 ccordoba12 changed the base branch from master to 5.x October 30, 2023 22:16
@ccordoba12 ccordoba12 changed the base branch from 5.x to master October 30, 2023 22:16
@ccordoba12
Copy link
Copy Markdown
Member

ccordoba12 commented Oct 30, 2023

Agreed.

@bnavigator, to include this in our next release, please run the following commands locally:

git checkout 5.x
git checkout pylint3
git rebase --onto 5.x master pylint3
git push -f origin pylint3

@ccordoba12 ccordoba12 added this to the v5.5.0 milestone Oct 30, 2023
@dalthviz dalthviz mentioned this pull request Oct 30, 2023
Closed
12 tasks
@ccordoba12
Copy link
Copy Markdown
Member

ccordoba12 commented Oct 31, 2023

Note: This requires to merge first PR python-lsp/python-lsp-server#475 and then sync our subrepo here so that our tests actually run with Pylint 3 and catch any possible regression.

@ccordoba12
Copy link
Copy Markdown
Member

ccordoba12 commented Oct 31, 2023

@bnavigator, I'm going to take care of finishing this one so we can be sure to include it in 5.5.

@ccordoba12 ccordoba12 changed the base branch from master to 5.x October 31, 2023 15:58
@pep8speaks

This comment was marked as off-topic.

Sign in to view
@ccordoba12 ccordoba12 closed this Oct 31, 2023
@ccordoba12 ccordoba12 reopened this Oct 31, 2023
ccordoba12
ccordoba12 reviewed Oct 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalthviz, these are a couple of comments for you before doing the release.

Comment thread .github/scripts/install.sh
micromamba remove --force python-lsp-server python-lsp-server-base -y

# Install Pylint 3 to run our tests with it
micromamba install pylint=3 -q -y
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these lines when PyLSP 1.9 is released.

Comment thread .github/scripts/install.sh
Comment on lines +48 to +49
# Install Pylint 3 to run our tests with it
pip install -U pylint
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And these lines too.

ccordoba12
ccordoba12 approved these changes Oct 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help with this @bnavigator!

@ccordoba12 ccordoba12 merged commit 150025e into spyder-ide:5.x Oct 31, 2023
ccordoba12 added a commit that referenced this pull request Oct 31, 2023
@ccordoba12
Merge from 5.x: PR #21470
ec13a25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@bnavigator bnavigator

Labels

component:Pylint type:Enhancement

Projects

None yet

Milestone

v5.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bnavigator @dalthviz @ccordoba12 @pep8speaks